Skip to content

fix: don't create src/ files during --mode migrate #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Passes in the root mode to writeStructure -> createStructure so it knows not to call createSrc during migration.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #841 (2d83ae2) into main (501ddb2) will decrease coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   92.18%   92.16%   -0.02%     
==========================================
  Files          84       84              
  Lines        4220     4226       +6     
  Branches      261      263       +2     
==========================================
+ Hits         3890     3895       +5     
- Misses        330      331       +1     
Flag Coverage Δ
create 71.97% <83.33%> (+0.01%) ⬆️
initialize 34.60% <16.66%> (-0.01%) ⬇️
migrate 71.21% <75.00%> (-2.06%) ⬇️
unit 52.48% <16.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writing/creation/rootFiles.ts 96.46% <0.00%> (-0.49%) ⬇️
src/create/createWithOptions.ts 69.11% <100.00%> (ø)
src/migrate/migrateWithOptions.ts 77.61% <100.00%> (ø)
src/steps/writing/creation/index.ts 100.00% <100.00%> (ø)
src/steps/writing/writeStructure.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit dd2392a into main Sep 19, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-src-in-migrate branch September 19, 2023 19:51
@github-actions
Copy link

🎉 This is included in version v1.29.44 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Don't create src/*.ts files during migration
1 participant